Re: hash join error improvement (old)

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: hash join error improvement (old)
Date: 2020-05-26 22:27:53
Message-ID: 20200526222753.GA2785@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On 2020-May-26, Tom Lane wrote:

> Are you sure you correctly identified the source of the bogus error
> report?

This version's better. It doesn't touch the write side at all.
On the read side, only report a short read as such if errno's not set.

This error isn't frequently seen. This page
(A Postgres fork; blames the error on the temp hash files being encrypted,
suggests to increase temp_buffers) is the only one I found.

There are more uses of BufFileRead that don't bother to distinguish
these two cases apart, though -- logtape.c, tuplestore.c,
gistbuildbuffers.c all do the same.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
hashjoin-3.patch text/x-diff 1.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andy Fan 2020-05-26 22:49:40 Re: Make the qual cost on index Filter slightly higher than qual cost on index Cond.
Previous Message Vik Fearing 2020-05-26 21:50:19 Re: Default gucs for EXPLAIN