Re: doc review for v13

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Subject: Re: doc review for v13
Date: 2020-04-26 16:13:24
Message-ID: 20200426161324.GS28974@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 14, 2020 at 02:47:54PM +0900, Michael Paquier wrote:
> On Sun, Apr 12, 2020 at 04:35:45PM -0500, Justin Pryzby wrote:
> > Added a few more.
> > And rebased on top of dbc60c5593f26dc777a3be032bff4fb4eab1ddd1
>
> Thanks for the patch set, I have applied the most obvious parts (more
> or less 1/3) to reduce the load. Here is a review of the rest.

Thanks - attached are the remaining undisputed portions..

> > +++ b/doc/src/sgml/ref/alter_table.sgml
> > @@ -889,7 +889,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
> > from the parent table will be created in the partition, if they don't
> > already exist.
> > If any of the <literal>CHECK</literal> constraints of the table being
> > - attached is marked <literal>NO INHERIT</literal>, the command will fail;
> > + attached are marked <literal>NO INHERIT</literal>, the command will fail;
> > such constraints must be recreated without the
> > <literal>NO INHERIT</literal> clause.
> > </para>
>
> It seems to me that both are actually correct here.

I think my text is correct. This would *also* be correct:

| If any <literal>CHECK</literal> constraint on the table being
| attached is marked <literal>NO INHERIT</literal>, the command will fail;

But not the hybrid: "If any OF THE .. is .."

--
Justin

Attachment Content-Type Size
v4-0001-doc-percent-encoding.patch text/x-diff 1.4 KB
v4-0002-docs-btree-deduplication.patch text/x-diff 1.1 KB
v4-0003-doc-pg_stat_progress_basebackup.patch text/x-diff 1.1 KB
v4-0004-Fix-docs-time-of-the.patch text/x-diff 3.1 KB
v4-0005-docs-Add-wait-events-for-recovery-conflicts.patch text/x-diff 1.3 KB
v4-0006-doc-Allow-users-to-limit-storage-reserved-by-repl.patch text/x-diff 1.5 KB
v4-0007-docs-s-evade-avoid.patch text/x-diff 1.8 KB
v4-0008-doc-Add-logical-replication-support-to-replicate-.patch text/x-diff 1.8 KB
v4-0009-doc-2014-pg_basebackup-Add-support-for-relocating.patch text/x-diff 1.0 KB
v4-0010-is-vs-are-plural.patch text/x-diff 2.7 KB
v4-0011-doc-Rename-the-recovery-related-wait-events.patch text/x-diff 1.2 KB
v4-0012-comment-typos.patch text/x-diff 3.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-04-26 17:40:54 Re: Poll: are people okay with function/operator table redesign?
Previous Message Andy Fan 2020-04-26 12:35:31 Re: Subplan result caching