Re: [Patch] Use internal pthreads reimplementation only when building with MSVC

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Sandro Mani <manisandro(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [Patch] Use internal pthreads reimplementation only when building with MSVC
Date: 2020-04-09 21:57:02
Message-ID: 20200409215702.GA22804@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

On 2020-Apr-08, Sandro Mani wrote:

> The following patch, which we added to build mingw-postgresql on Fedora,
> makes the internal minimal pthreads reimplementation only used when building
> with MSVC, as on MINGW it causes symbol collisions with the symbols provided
> my winpthreads.

Are there any build-system tweaks needed to enable use of winpthreads?
If none are needed, why are all our mingw buildfarm members building
correctly? I suggest that if you want to maintain "mingw-postgresql
built on Fedora", it would be a good idea to have a buildfarm animal
that tests it on a recurring basis.

Please do submit patches as separate attachments rather than in the
email body.

--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-04-09 22:32:49 Re: Catalog invalidations vs catalog scans vs ScanPgRelation()
Previous Message Alvaro Herrera 2020-04-09 21:49:47 Re: pgsql: Rationalize GetWalRcv{Write,Flush}RecPtr().