Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Jose Luis Tallon <jltallon(at)adv-solutions(dot)net>
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly
Date: 2020-04-01 13:08:36
Message-ID: 20200401130836.GT14618@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Apr 01, 2020 at 06:57:18AM -0500, Justin Pryzby wrote:
> Alexey suggested that those changes should be done as a separate patch, with
> the tablespace options built on top. Which makes sense. I had quite some fun
> rebasing these with patches in that order.
>
> However, I've kept my changes separate from Alexey's patch, to make it easier
> for him to integrate. So there's "fix!" commits which are not logically
> separate and should be read as if they're merged with their parent commits.
> That makes the patchset look kind of dirty. So I'm first going to send the
> "before rebase" patchset. There's a few fixme items, but I think this is in
> pretty good shape, and I'd appreciate review.
>
> I'll follow up later with the "after rebase" patchset.

Attached. As I said, the v15 patches might be easier to review, even though
v16 is closer to what's desirable to merge.

> Maybe Alexey will want to integrate that.

Or maybe you'd want me to squish my changes into yours and resend after any
review comments ?

--
Justin

Attachment Content-Type Size
v16-0001-Change-REINDEX-CLUSTER-to-accept-an-option-list.patch text/x-diff 20.1 KB
v16-0002-Allow-REINDEX-to-change-tablespace.patch text/x-diff 30.6 KB
v16-0003-fix-Parenthesized-syntax-REINDEX-TABLESPACE.patch text/x-diff 10.0 KB
v16-0004-Allow-CLUSTER-and-VACUUM-FULL-to-change-tablespa.patch text/x-diff 22.8 KB
v16-0005-fixes2.patch text/x-diff 4.3 KB
v16-0006-fix-Parenthesized-syntax-VACUUM-CLUSTER-TABLESPA.patch text/x-diff 17.1 KB
v16-0007-Implement-vacuum-full-cluster-INDEX_TABLESPACE-t.patch text/x-diff 14.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-04-01 13:32:35 Re: Some problems of recovery conflict wait events
Previous Message James Coleman 2020-04-01 13:05:27 Re: [PATCH] Incremental sort (was: PoC: Partial sort)