Re: shared-memory based stats collector

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: alvherre(at)2ndquadrant(dot)com
Cc: andres(at)anarazel(dot)de, michael(at)paquier(dot)xyz, thomas(dot)munro(at)gmail(dot)com, tomas(dot)vondra(at)2ndquadrant(dot)com, ah(at)cybertec(dot)at, magnus(at)hagander(dot)net, robertmhaas(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, pgsql-hackers(at)postgresql(dot)org
Subject: Re: shared-memory based stats collector
Date: 2020-04-01 08:37:23
Message-ID: 20200401.173723.394731022459464352.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Conflicted with 616ae3d2b0, so rebased.

I made some cleanup. (v30)

- Added comments for members of dshash_seq_scans.
- Some style fix and comment fix of dshash.

- Cleaned up more usage of the word "stat(istics) collector" in comments,
- Changed the GUC attribute STATS_COLLECTOR to STATS_ACTIVITY
- Removed duplicate setup of MyBackendType and ps display in PgArchiverMain
- Removed B_STATS_COLLECTOR from BackendType and removed related code.
- Corrected the comment of PgArchiverMain, which mentioned "argv/argc".

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v30-0001-Use-standard-crash-handler-in-archiver.patch text/x-patch 1.7 KB
v30-0002-sequential-scan-for-dshash.patch text/x-patch 8.4 KB
v30-0003-Add-conditional-lock-feature-to-dshash.patch text/x-patch 6.2 KB
v30-0004-Make-archiver-process-an-auxiliary-process.patch text/x-patch 16.9 KB
v30-0005-Shared-memory-based-stats-collector.patch text/x-patch 246.4 KB
v30-0006-Doc-part-of-shared-memory-based-stats-collector.patch text/x-patch 21.5 KB
v30-0007-Remove-the-GUC-stats_temp_directory.patch text/x-patch 9.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-04-01 08:42:49 Re: recovery_target_action=pause with confusing hint
Previous Message Fujii Masao 2020-04-01 08:27:22 Re: [BUG] non archived WAL removed during production crash recovery