Re: Planning counters in pg_stat_statements (using pgss_store)

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Sergei Kornilov <sk(at)zsrv(dot)org>
Cc: "imai(dot)yoshikazu(at)fujitsu(dot)com" <imai(dot)yoshikazu(at)fujitsu(dot)com>, legrand legrand <legrand_legrand(at)hotmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
Date: 2020-03-20 19:30:04
Message-ID: 20200320193004.rqgf3iim4fugq3sm@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Mar 20, 2020 at 05:09:05PM +0300, Sergei Kornilov wrote:
> Hello
> Yet another is missed in docs: total_time

Oh good catch! I rechecked many time the field, and totally missed that the
documentation is referring to the view, which has an additional column, and not
the function. Attached v9 fixes that.

> I specifically verified that the new loaded library works with the old version of the extension in the database. I have not noticed issues here.

Thanks for those extra checks.

> > 2.2% is a bit large but I think it is still acceptable because people using this feature
> > might take account that some overhead will happen for additional calling of a
> > gettime function.
> I will be happy even with 10% overhead due to enabled track_planning... (but in this case disabled by default) log_min_duration_statement = 0 with log parsing is much more expensive.
> I think 1-2% is acceptable and we can set track_planning = on by default as patch does.
> > * Rows for executor time are changed from {total/min/max/mean/stddev}_time to {total/min/max/mean/stddev}_exec_time.
> Maybe release it as 2.0 version instead of minor update 1.18?

I don't have an opinion on that, I'd be fine with any version. I kept 1.18 in
the patch for now.

Attachment Content-Type Size
v9-0001-Pass-query-string-to-the-planner.patch text/x-diff 10.4 KB
v9-0002-Add-planning-counters-to-pg_stat_statements.patch text/x-diff 47.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2020-03-20 19:34:12 Re: SQL/JSON: functions
Previous Message Corey Huinker 2020-03-20 18:16:06 Re: Add A Glossary