| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, Liudmila Mantrova <l(dot)mantrova(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, David Steele <david(at)pgmasters(dot)net>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, vladimirlesk(at)yandex-team(dot)ru, dsarafan(at)yandex-team(dot)ru |
| Subject: | Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line |
| Date: | 2020-03-13 00:18:37 |
| Message-ID: | 20200313001837.GC1739@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 12, 2020 at 12:50:17PM -0300, Alvaro Herrera wrote:
> Thanks, looks good. I don't think we *need* the MAXPGPATH restriction
> really -- I was thinking in a StringInfo kind of approach where you just
> append the stuff you need without having to think about the buffer
> length.
Oh, OK. I missed your point then. No problem with that by doing it
as the attached. There is one small trick because of
make_native_path() though.
> Aha, good. I would still put the new "archive.c" entry on its own line,
> and just keep the other two lines unchanged. (That preserves the
> perhaps non-obvious property that all entries that start with the same
> letter are in the same line.)
No issues with that either. Are you fine with the updated version
attached for 0001?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Move-routine-generating-restore_command-to-src-co.patch | text/x-diff | 8.3 KB |
| v3-0002-Add-c-restore-target-wal-to-pg_rewind.patch | text/x-diff | 23.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Laurenz Albe | 2020-03-13 00:19:33 | Re: Berserk Autovacuum (let's save next Mandrill) |
| Previous Message | Justin Pryzby | 2020-03-12 23:40:15 | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |