Re: Planning counters in pg_stat_statements (using pgss_store)

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: "imai(dot)yoshikazu(at)fujitsu(dot)com" <imai(dot)yoshikazu(at)fujitsu(dot)com>
Cc: legrand legrand <legrand_legrand(at)hotmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
Date: 2020-03-12 06:31:09
Message-ID: 20200312063109.bzw4fbk64gpcbhhh@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Hi Imai-san,

On Thu, Mar 12, 2020 at 05:28:38AM +0000, imai(dot)yoshikazu(at)fujitsu(dot)com wrote:
> Hi Julien,
> On Mon, Mar 9, 2020 at 10:32 AM, Julien Rouhaud wrote:
> > On Thu, Mar 05, 2020 at 01:26:19PM -0700, legrand legrand wrote:
> > > Please consider PG13 shortest path ;o)
> > >
> > > My one is parse->queryId != UINT64CONST(0) in pgss_planner_hook().
> > > It fixes IVM problem (verified),
> > > and keep CTAS equal to pgss without planning counters (verified too).
> >
> > I still disagree that hiding this problem is the right fix, but since no one
> > objected here's a v5 with that behavior. Hopefully this will be fixed in v14.
> Is there any case that query_text will be NULL when executing pg_plan_query?

With current sources, there are no cases where the query text isn't provided

> If query_text will be NULL, we need to add codes to avoid errors in
> pgss_store like as current patch. If query_text will not be NULL, we should
> add Assert in pg_plan_query so that other developers can notice that they
> would not mistakenly set query_text as NULL even without using pgss_planning
> counter.

I totally agree. I already had such assert locally, and regression tests pass
without any problem. I'm attaching a v6 with that extra assert. If the
first patch is committed, it'll now be a requirement to provide it. Or if
people think it's not, it'll make sure that we'll discuss it.

Attachment Content-Type Size
v6-0001-Pass-query-string-to-the-planner.patch text/x-diff 10.7 KB
v6-0002-Add-planning-counters-to-pg_stat_statements.patch text/x-diff 45.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2020-03-12 06:32:12 Re: Online verification of checksums
Previous Message David Rowley 2020-03-12 06:14:12 Re: Berserk Autovacuum (let's save next Mandrill)