Re: Planning counters in pg_stat_statements (using pgss_store)

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: legrand legrand <legrand_legrand(at)hotmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Planning counters in pg_stat_statements (using pgss_store)
Date: 2020-03-09 10:31:42
Message-ID: 20200309103142.GA45401@nol
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 05, 2020 at 01:26:19PM -0700, legrand legrand wrote:
> Please consider PG13 shortest path ;o)
>
> My one is parse->queryId != UINT64CONST(0) in pgss_planner_hook().
> It fixes IVM problem (verified),
> and keep CTAS equal to pgss without planning counters (verified too).

I still disagree that hiding this problem is the right fix, but since no one
objected here's a v5 with that behavior. Hopefully this will be fixed in v14.

Attachment Content-Type Size
v5-0001-Pass-query-string-to-the-planner.patch text/plain 10.4 KB
v5-0002-Add-planning-counters-to-pg_stat_statements.patch text/plain 45.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2020-03-09 11:13:47 Re: Run-time pruning for ModifyTable
Previous Message Kuntal Ghosh 2020-03-09 10:08:29 Re: [Patch] pg_rewind: options to use restore_command from recovery.conf or command line