Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)postgresql(dot)org, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)
Date: 2020-03-07 21:40:10
Message-ID: 20200307214010.GB1357@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Mar 07, 2020 at 03:14:37PM +0100, Fabien COELHO wrote:
> The documentation sentences could probably be improved "for for", "used ...
> used". Maybe:

> ISTM that several instances of: "pg_ls_dir_files(..., true, false);" should
> be "pg_ls_dir_files(..., true, DIR_HIDE);".

> Alas, ISTM that there are no tests on any of these functions:-(

Addressed these.

And reordered the last two commits to demonstrate and exercize the behavior
change in regress test.

--
Justin

Attachment Content-Type Size
v8-0001-BUG-in-errmsg.patch text/x-diff 950 bytes
v8-0002-Document-historic-behavior-about-hiding-directori.patch text/x-diff 1.7 KB
v8-0003-Document-historic-behavior-about-hiding-directori.patch text/x-diff 905 bytes
v8-0004-pg_ls_tmpdir-to-show-directories-recursively.patch text/x-diff 14.9 KB
v8-0005-Change-pg_ls_logdir-to-ignore-error-if-initial-to.patch text/x-diff 3.0 KB
v8-0006-Change-logdir-and-archive_statusdir-to-include-di.patch text/x-diff 7.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-03-07 21:44:48 Re: Refactor compile-time assertion checks for C/C++
Previous Message Pavel Stehule 2020-03-07 21:26:58 Re: range_agg