Re: pgsql: walreceiver uses a temporary replication slot by default

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Sergei Kornilov <sk(at)zsrv(dot)org>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: pgsql: walreceiver uses a temporary replication slot by default
Date: 2020-02-18 02:43:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Mon, Feb 17, 2020 at 04:57:04PM +0300, Sergei Kornilov wrote:
> Thank you, here is updated patch


> I changed this comments because they describes behavior during
> change value of wal_receiver_create_temp_slot. But yes, I need to
> add some comments to RequestXLogStreaming.

I have reworked that part, adding more comments about the use of GUC
parameters when establishing the connection to the primary for a WAL
receiver. And also I have added an extra comment to walreceiver.c
about the use of GUcs in general, to avoid this stuff again in the
future. There were some extra nits with the format of

>> As per the discussion done on this thread, let's also switch the
>> parameter default to be disabled.
> Done (my vote is also for disabling this option by default).

We visibly tend to move in this direction, at least based on our
discussion. Let's see where this leads. For now, I have registered
this patch to next CF (,
with yourself as author and myself as reviewer, and then let's wait
for mainly Peter E. and others for more input.

Attachment Content-Type Size
0001-v3-change-wal_receiver_create_temp_slot.patch text/x-diff 9.4 KB

In response to


Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-02-18 04:11:51 pgsql: Remove duplicated words in comments
Previous Message Michael Paquier 2020-02-18 01:55:54 pgsql: Fix grammar in monitoring.sgml

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2020-02-18 02:56:15 Re: [HACKERS] WAL logging problem in 9.4.3?
Previous Message Thomas Munro 2020-02-18 02:39:31 Re: Parallel copy