| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: [PATCH v1] pg_ls_tmpdir to show directories |
| Date: | 2019-12-28 21:09:53 |
| Message-ID: | 20191228210953.GJ12890@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Here's a version which uses an array of directory_fctx, rather than of DIR and
location. That avoids changing the data structure and collatoral implications
to pg_ls_dir().
Currently, this *shows* subdirs of subdirs, but doesn't decend into them.
So I think maybe toplevel subdirs should be shown, too.
And maybe the is_dir flag should be re-introduced (although someone could call
pg_stat_file if needed).
I'm interested to hear feedback on that, although this patch still isn't great.
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-BUG-in-errmsg.patch | text/x-diff | 943 bytes |
| v4-0002-pg_ls_tmpdir-to-show-directories.patch | text/x-diff | 8.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2019-12-28 21:16:52 | Re: TAP testing for psql's tab completion code |
| Previous Message | legrand legrand | 2019-12-28 20:15:09 | Incremental View Maintenance: ERROR: out of shared memory |