Re: [HACKERS] Restricting maximum keep segments by repslots

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: jgdr(at)dalibo(dot)com
Cc: andres(at)anarazel(dot)de, michael(at)paquier(dot)xyz, sawada(dot)mshk(at)gmail(dot)com, peter(dot)eisentraut(at)2ndquadrant(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, thomas(dot)munro(at)enterprisedb(dot)com, sk(at)zsrv(dot)org, michael(dot)paquier(at)gmail(dot)com
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
Date: 2019-12-26 09:08:12
Message-ID: 20191226.180812.1478956694079662301.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 24 Dec 2019 21:26:14 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> The attached v17 patch is changed in the follwing points.
>
> - Rebased to the current master.
>
> - Change KeepLogSeg not to emit the message "Slot %s lost %ld
> segment(s)" if the slot list is not changed.
>
> - Documentation is fixed following the change of state names.
>
> - Change GetLsnAvailability returns more correct state for wider
> situations. It returned a wrong status when max_slot_wal_keep_size
> is smaller than max_wal_size, or when max_slot_wal_keep_size is
> increased so that the new value covers the restart_lsn of a slot
> that have lost required segments in the old setting.
>
> Since it is needed by the above change, I revived
> GetOldestXLogFileSegNo() that was removed in v15 as
> FindOldestXLogFileSegNo() in a bit different shape.

I'd like to re-enter this patch to the next cf.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2019-12-26 09:19:53 Re: Expose lock group leader pid in pg_stat_activity
Previous Message Kyotaro Horiguchi 2019-12-26 09:03:21 Re: [HACKERS] WAL logging problem in 9.4.3?