Re: Memory-Bounded Hash Aggregation

From: Andres Freund <andres(at)anarazel(dot)de>
To: Jeff Davis <pgsql(at)j-davis(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Taylor Vesely <tvesely(at)pivotal(dot)io>, Adam Lee <ali(at)pivotal(dot)io>, Melanie Plageman <mplageman(at)pivotal(dot)io>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Memory-Bounded Hash Aggregation
Date: 2019-12-05 22:14:53
Message-ID: 20191205221453.27hn74xmeq6cii47@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2019-12-05 12:55:51 -0800, Jeff Davis wrote:
> On Thu, 2019-11-28 at 18:46 +0100, Tomas Vondra wrote:
> > And it's not clear to me why we should remove part of the comment
> > before
> > TupleHashTableHash.
>
> It looks like 5dfc1981 changed the signature of TupleHashTableHash
> without updating the comment, so it doesn't really make sense any more.
> I just updated the comment as a part of my patch, but it's not related.
>
> Andres, comments? Maybe we can just commit a fix for that comment and
> take it out of my patch.

Fine with me!

- Andres

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2019-12-05 22:29:36 Re: Update minimum SSL version
Previous Message Tomas Vondra 2019-12-05 22:04:57 Re: Memory-Bounded Hash Aggregation