| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Euler Taveira <euler(at)timbira(dot)com(dot)br> |
| Subject: | Re: [Patch] Add a reset_computed_values function in pg_stat_statements |
| Date: | 2019-12-01 01:13:06 |
| Message-ID: | 20191201011306.GB2355@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Nov 05, 2019 at 11:03:58AM +1300, Thomas Munro wrote:
> In contrib/pg_stat_statements/pg_stat_statements.c, you need to
> declare or define entry_reset_computed() before you use it. I suppose
> your compiler must be warning about that. I personally put
> "COPT=-Wall -Werror" into src/Makefile.custom to make sure that I
> don't miss any warnings. That's also what http://cfbot.cputube.org/
> does (a thing that does a full check-world on all registered patches
> to look for such problems).
Still the same problem which has not been addressed after a couple of
weeks, so I am marking the entry as returned with feedback.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2019-12-01 01:13:31 | Protocol problem with GSSAPI encryption? |
| Previous Message | Michael Paquier | 2019-12-01 01:10:46 | Re: [Proposal] Add accumulated statistics |