Re: [PATCH] Do not use StdRdOptions in Access Methods

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Amit Langote <amitlangote09(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Nikolay Shaplov <dhyan(at)nataraj(dot)su>, Dent John <denty(at)qqdd(dot)eu>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Iwata, Aya" <iwata(dot)aya(at)jp(dot)fujitsu(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Subject: Re: [PATCH] Do not use StdRdOptions in Access Methods
Date: 2019-11-13 05:18:03
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Nov 13, 2019 at 10:52:52AM +0900, Amit Langote wrote:
> Thanks for chiming in about that. I guess that means that we don't
> need those macros, except GET_STRING_RELOPTION_LEN() that's used in
> allocateReloptStruct(), which can be moved to reloptions.c. Is that
> correct?

I have been looking on the net to see if there are any traces of code
using those macros, but could not find any. The last trace of a macro
use is in 8ebe1e3, which just relies on GET_STRING_RELOPTION_LEN. So
it looks rather convincing now to just remove this code. Attached is
a patch for that. There could be an argument for keeping
GET_STRING_RELOPTION actually which is still useful to get a string
value in an option set using the stored offset, and we have
the recently-added dummy_index_am in this category. Any thoughts?

Attachment Content-Type Size
relopts-cleanup.patch text/x-diff 7.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Mercha 2019-11-13 05:23:27 Re: SPI error with non-volatile functions
Previous Message Andres Freund 2019-11-13 05:13:59 Re: SPI error with non-volatile functions