|From:||Andres Freund <andres(at)anarazel(dot)de>|
|To:||Craig Ringer <craig(at)2ndquadrant(dot)com>|
|Cc:||PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Allow cluster_name in log_line_prefix|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On 2019-10-28 12:33:00 +0800, Craig Ringer wrote:
> I was recently surprised to notice that log_line_prefix doesn't support a
> cluster_name placeholder. I suggest adding one. If I don't hear objections
> I'll send a patch.
> Before anyone asks "but why?!":
> * A constant (short) string in log_line_prefix is immensely useful when
> working with logs from multi-node systems. Whether that's physical
> streaming replication, logical replication, Citus, whatever, it doesn't
> matter. It's worth paying the small storage price for sanity when looking
> at logs.
> * Yes you can embed it directly into log_line_prefix. But then it gets
> copied by pg_basebackup or whatever you're using to clone standbys etc, so
> you can easily land up with multiple instances reporting the same name.
> This rather defeats the purpose.
+1. For a while this was part of the patch that added cluster_name
(possibly worthwhile digging it up from that thread), but some people
thought it was unnecessary, so it was excised from the patch to get the
|Next Message||Pavel Stehule||2019-10-31 16:36:27||Re: Adding percentile metrics to pg_stat_statements module|
|Previous Message||Jim Finnerty||2019-10-31 15:56:22||Re: function calls optimization|