Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, buschmann(at)nidsa(dot)net, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after pg_upgrade from PG11 to PG12
Date: 2019-10-15 00:18:17
Message-ID: 20191015001817.zei45apgpu5dzngr@development
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs pgsql-hackers

On Mon, Oct 14, 2019 at 06:35:38PM +0200, Tomas Vondra wrote:
> ...
>Aha! I forgot we copy the necessary stuff into pg_attribute. Thanks for
>clarifying, I'll polish and push the fix shortly.

I've pushed and backpatched the fix. Attached are similar fixes for the
existing pg_upgrade checks for pg_catalog.line and pg_catalog.unknown
types, which have the same issues with composite types and domains.

There are some additional details & examples in the commit messages.

I've kept this in two patches primarily because of backpatching - the
line fix should go back up to 9.4, the unknown is for 10.


Tomas Vondra
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Correct-the-check-for-pg_catalog.line-in-pg_upgrade.patch text/plain 3.4 KB
0002-Correct-the-check-for-pg_catalog.unknown-in-pg_upgra.patch text/plain 3.1 KB

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message Jeff Janes 2019-10-15 00:35:16 Re: BUG #16054: Slowest individual queries
Previous Message Tom Lane 2019-10-14 23:30:08 Re: BUG #16055: pgAdmin 4 - ERROR: operator does not exist: - oid

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-10-15 00:54:55 Re: "pg_ctl: the PID file ... is empty" at end of make check
Previous Message legrand legrand 2019-10-14 22:20:17 Re: Columns correlation and adaptive query optimization