| From: | Joe Nelson <joe(at)begriffs(dot)com> |
|---|---|
| To: | Alvaro Herrera from 2ndQuadrant <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Change atoi to strtol in same place |
| Date: | 2019-09-10 04:02:49 |
| Message-ID: | 20190910040249.GA25585@begriffs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera from 2ndQuadrant wrote:
> Okay, so who is submitting a new version here? Surafel, Joe?
I've attached a revision that uses pg_strtoint64 from str2int-10.patch
(posted in <alpine(dot)DEB(dot)2(dot)21(dot)1909032007230(dot)21690(at)lancre>). My patch is
based off that one and c5bc7050af.
It covers the same front-end utilities as atoi-to-strtol-v2.patch. Other
utilities in the pg codebase still have atoi inside, but I thought I'd
share my progress to see if people like the direction. If so, I can
update the rest of the utils.
I added a helper function to a new file in src/fe_utils, but had to
modify Makefiles in ways that might not be too clean. Maybe there's a
better place for the function.
--
Joe Nelson https://begriffs.com
| Attachment | Content-Type | Size |
|---|---|---|
| atoi-to-strtol-v3.patch | text/x-patch | 16.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sandeep Thakkar | 2019-09-10 04:04:34 | Re: PostgreSQL 12 Beta 4 |
| Previous Message | Michael Paquier | 2019-09-10 03:05:25 | Re: refactoring - share str2*int64 functions |