Re: Libpq support to connect to standby server as priority

From: Alvaro Herrera from 2ndQuadrant <alvherre(at)alvh(dot)no-ip(dot)org>
To: Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>
Cc: "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dave Cramer <pg(at)fastcrypt(dot)com>, Jing Wang <jingwangian(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Libpq support to connect to standby server as priority
Date: 2019-09-09 17:19:49
Message-ID: 20190909171949.GA31491@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Question about 0001. In the CONNECTION_SETENV state, you end by falling
through to the CONNECTION_CHECK_TARGET case; but in that switch it seems
a bit unnatural to do that. I think doing "goto keep_trying" is another
way of doing the same thing, but more in line with what every other
piece of code does.

Álvaro Herrera
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachment Content-Type Size
0001-Restructure-the-code-to-remove-duplicate-code.patch text/x-diff 4.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Nikita Glukhov 2019-09-09 17:30:00 Re: Bug in GiST paring heap comparator
Previous Message Magnus Hagander 2019-09-09 17:04:05 Re: having issues with PG12 debian packaging repository