Re: Statement timeout in pg_rewind

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Alexander Kukushkin <cyberdemn(at)gmail(dot)com>
Cc: David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Statement timeout in pg_rewind
Date: 2019-08-28 02:51:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Tue, Aug 27, 2019 at 10:45:27AM +0200, Alexander Kukushkin wrote:
> Done, please see the next version attached.

I have made the new error message consistent with run_simple_query to
avoid more work to translators and because it is possible to know
immediately the code path involved thanks to the SQL query, then
applied the fix down to 9.5 where pg_rewind has been added. Please
note that your patch had a warning as "result" is not needed in

idle_in_transaction_session_timeout only applies to 9.6 and newer
versions. lock_timeout (imagine a concurrent lock on pg_class for
example) and statement_timeout can cause issues, but the full set gets
disabled as your patch did and as mentioned upthread.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-08-28 02:52:10 Re: Cleanup isolation specs from unused steps
Previous Message Ian Barwick 2019-08-28 01:57:24 Re: [PATCH] Make configuration file "include" directive handling more robust