Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
Date: 2019-07-19 03:53:47
Message-ID: 20190719035347.GJ1859@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi Tom,
(moving to -hackers)

On Wed, Jul 17, 2019 at 10:26:45PM +0000, Tom Lane wrote:
> Sync our copy of the timezone library with IANA release tzcode2019b.
>
> A large fraction of this diff is just due to upstream's somewhat
> random decision to rename a bunch of internal variables and struct
> fields. However, there is an interesting new feature in zic:
> it's grown a "-b slim" option that emits zone files without 32-bit
> data and other backwards-compatibility hacks. We should consider
> whether we wish to enable that.

This is causing a compilation warning on Windows:
https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=whelk&dt=2019-07-19%2001%3A41%3A13&stg=make

"C:\buildfarm\buildenv\HEAD\pgsql.build\pgsql.sln" (Standardziel) (1)
->
"C:\buildfarm\buildenv\HEAD\pgsql.build\zic.vcxproj" (Standardziel)
(72) ->
src/timezone/zic.c(2401): warning C4804: '-' : unsafe use of type
'bool' in operation
[C:\buildfarm\buildenv\HEAD\pgsql.build\zic.vcxproj]

Buildfarm members using VS like whelk complains about that, and I can
see the warning myself.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-07-19 04:06:01 Re: pgsql: Sync our copy of the timezone library with IANA release tzcode20
Previous Message Michael Paquier 2019-07-19 02:44:33 pgsql: Doc: clarify when table rewrites happen with column addition and

Browse pgsql-hackers by date

  From Date Subject
Next Message Hubert Zhang 2019-07-19 03:57:55 How to create named portal except cursor?
Previous Message Chapman Flack 2019-07-19 03:39:56 Re: [HACKERS] xpath improvement suggestion