Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: YunQiang Su <wzssyqa(at)gmail(dot)com>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build
Date: 2019-06-17 16:32:07
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs


On 2019-06-16 12:16:53 -0400, Tom Lane wrote:
> (We should not do anything if --disable-spinlocks has been specified,
> btw, since then we don't need those asm commands to work. This is
> and would remain the workaround for building PG for MIPS-I, if some
> benighted soul insists on doing that.)

I think we're pretty much at the point where we should just rip out all
of our own spinlock implementations for non-common platforms, and solely
rely on compiler intrinsics... The open coded ASM really doesn't age
very well, and there's very little chance of us actually testing them


Andres Freund

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2019-06-17 16:48:39 Re: BUG #15851: Concurrent Refresh of Materialized views not preserving the order of the underlying query
Previous Message PG Bug reporting form 2019-06-17 15:43:05 BUG #15856: The program "postgres" was found by "initdb" but was not the same version as initdb.