On Mon, Jun 10, 2019 at 11:49:03PM -0700, Andres Freund wrote: > Well, all four. Given it's just copied code I don't see much code in > splitting the commit anymore.
Thanks for pushing the fix, the result looks fine.
> I noticed some other uglyness: check_timezone calls interval_in(), > without any checks. Not a huge fan of doing all that in postmaster, even > leaving the wrong error reporting aside :(. But that seems like a > plenty different enough issue to fix it separately, if we decide we want > to do so.