Re: New EXPLAIN option: ALL

From: David Fetter <david(at)fetter(dot)org>
To: Sergei Kornilov <sk(at)zsrv(dot)org>
Cc: PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New EXPLAIN option: ALL
Date: 2019-05-07 16:28:22
Message-ID: 20190507162822.GK28936@fetter.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 07, 2019 at 11:13:15AM +0300, Sergei Kornilov wrote:
> Hi
>
> I liked this idea.
>
> + timing_set = true;
> + es->timing = defGetBoolean(opt);
> + summary_set = true;
> + es->timing = defGetBoolean(opt);
>
> second es->timing should be es->summary, right?

You are correct! Sorry about the copy-paste-o.

Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

Attachment Content-Type Size
v2-0001-Add-an-ALL-option-to-EXPLAIN.patch text/x-diff 4.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Fetter 2019-05-07 16:31:29 Re: New EXPLAIN option: ALL
Previous Message Magnus Hagander 2019-05-07 16:27:08 Re: Typos and wording in jsonpath-exec.c