| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
| Cc: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, amitlangote09(at)gmail(dot)com |
| Subject: | Re: partitioned tables referenced by FKs |
| Date: | 2019-04-01 20:03:36 |
| Message-ID: | 20190401200336.GA17585@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-Mar-29, Jesper Pedersen wrote:
> I ran my test cases for this feature, and havn't seen any issues.
>
> Therefore I'm marking 1877 as Ready for Committer. If others have additional
> feedback feel free to switch it back.
Thanks!
I found two issues today. One, server side, is that during cloning for
partition attach we were not checking for concurrent deletion of
referenced tuples in partitions. I added an isolation spec test for
this. To fix the bug, added a find_all_inheritors() to lock all
partitions with ShareRowExclusiveLock.
Another is that psql's \d failed for versions < 12, because we were
inconditionally adding an "AND conparentid = 0" clause.
I also reworked CloneForeignKeyConstraints. The previous style was
being forced by the old recursing method; now we can make it a lot
simpler -- it's now just two subroutine calls.
I'm satisfied with this patch now, so I intend to push early tomorrow.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v10-0001-support-FKs-referencing-partitioned-tables.patch | text/x-diff | 104.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | legrand legrand | 2019-04-01 20:04:07 | RE: minimizing pg_stat_statements performance overhead |
| Previous Message | Peter Geoghegan | 2019-04-01 19:14:59 | Re: C_C_A animal on HEAD gets stuck in initdb |