From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: psql display of foreign keys |
Date: | 2019-03-04 19:41:00 |
Message-ID: | 20190304194100.GA9190@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2019-Feb-28, Michael Paquier wrote:
> On Wed, Feb 27, 2019 at 03:37:23PM -0300, Alvaro Herrera wrote:
> > +pg_partition_ancestors(PG_FUNCTION_ARGS)
> > +{
> > + Oid relid = PG_GETARG_OID(0);
> > + FuncCallContext *funcctx;
> > + ListCell **next;
> > +
> > + if (!check_rel_can_be_partition(relid))
> > + PG_RETURN_NULL();
>
> Not returning an empty set here? ;)
Yeah, I adapted to what was there then, but in the original coding I had
the SRF_RETURN_DONE that you committed for pg_partition_tree.
> I would have added tests with pg_partition_ancestors(NULL) and
> pg_partition_ancestors(0) for consistency with the rest.
Done.
> Except that and the ancestor tracking for inheritance, the shape of
> the patch looks good to me.
Thanks for reviewing! I have pushed with your proposed changes.
Here's the patch I'm really interested about :-)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
v5-0001-fix-psql-display-of-FKs.patch | text/x-diff | 17.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bossart, Nathan | 2019-03-04 20:03:37 | Re: reloption to prevent VACUUM from truncating empty pages at the end of relation |
Previous Message | Julien Rouhaud | 2019-03-04 19:31:09 | Re: Checksum errors in pg_stat_database |