Re: minor fix in CancelVirtualTransaction

From: Andres Freund <andres(at)anarazel(dot)de>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minor fix in CancelVirtualTransaction
Date: 2019-02-03 10:26:11
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2019-01-11 18:35:13 -0300, Alvaro Herrera wrote:
> On 2019-Jan-04, Peter Eisentraut wrote:
> > Your reasoning seems correct to me.
> >
> > Maybe add a code comment along the lines of "once we have found the
> > right ... we don't need to check the remaining ...".
> >
> > Or, you can make this even more clear by comparing the backendId
> > directly with the proc entry:
> I did both (the second idea was a non-obvious very nice cleanup --
> thanks). Patch attached.
> However, now I realize that this code is not covered at all, so I'll put
> this patch to sleep until I write some test for it.

Given that the CF entry has been waiting on this update I'll mark this
as returned with feedback, rather than moving to the next CF.


Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-02-03 10:28:18 Re: [PATCH] Add support for ON UPDATE/DELETE actions on ALTER CONSTRAINT
Previous Message Andres Freund 2019-02-03 10:23:16 Re: Undo logs