Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well
Date: 2019-02-01 03:42:36
Message-ID: 20190201034236.GG2179@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Thu, Jan 31, 2019 at 11:19:11AM +0900, Michael Paquier wrote:
> Ah yes, good point about CFLAGS and LDFLAGS. It would be better to
> add a comment about that and document the difference, aka "prepend" or
> "append" the flag values.
>
> CXXFLAGS applies to compiler options like -g -O2 which you would like
> to enforce for the C++ compiler, so it seems to me that like CFLAGS
> the custom values should be added at the end and not at the beginning,
> no?

Attached is a patch doing that. Thoughts?
--
Michael

Attachment Content-Type Size
pgxs-add-flags-michael.patch text/x-diff 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-02-01 03:44:05 Re: BUG #15548: Unaccent does not remove combining diacritical characters
Previous Message Amit Kapila 2019-02-01 02:30:56 Re: WIP: Avoid creation of the free space map for small tables