Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.

From: Andres Freund <andres(at)anarazel(dot)de>
To: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.
Date: 2019-01-14 23:37:14
Message-ID: 20190114233714.mi77d2p25juwpyjx@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On 2019-01-07 17:03:20 +0530, Amit Khandekar wrote:
> On Sat, 5 Jan 2019 at 02:09, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On 2019-01-03 13:40:42 -0500, Tom Lane wrote:
> > > I noticed that this patch has broken restores of existing dump files:
> > >
> > > psql:testbed.public.backup:82: ERROR: unrecognized configuration parameter "default_with_oids"
> > >
> > > Quite aside from the fact that this won't work if the user tries to
> > > restore in single-transaction or no-error mode, this is really really
> > > unhelpful because it's impossible to tell whether the error is
> > > ignorable or not, except by digging through the dump file.
> > >
> > > What you should do is restore that GUC, but add a check-hook that throws
> > > an error for an attempt to set it to "true".
>
> Attached is a patch that does this.

Thanks! I've pushed this, after some minor editorialization (hiding the
GUC, shortened description, shortened error message).

Regards,

Andres

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2019-01-14 23:46:18 Re: [HACKERS] Surjective functional indexes
Previous Message James Coleman 2019-01-14 23:23:52 Re: Proving IS NOT NULL inference for ScalarArrayOpExpr's

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-01-14 23:48:51 pgsql: Fix typos in documentation and for one wait event
Previous Message Andres Freund 2019-01-14 23:36:07 pgsql: Re-add default_with_oids GUC to avoid breaking old dump files.