Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Luis Carril <luis(dot)carril(at)swarm64(dot)com>, "pgsql-bugs(at)lists(dot)postgresql(dot)org" <pgsql-bugs(at)lists(dot)postgresql(dot)org>, PG Bug reporting form <noreply(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction
Date: 2018-12-20 00:31:40
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-bugs

On Wed, Dec 19, 2018 at 06:12:12PM +0900, Etsuro Fujita wrote:
> I think so too. I think it might be better to add regression tests for the
> view case as well, though.


>> Would you like to
>> update the patch yourself?
> I'd be happy if you worked on that.

Attached is the patch with two new test cases blowing with wal_level =
minimal. On HEAD, I suggest that we use RELKIND_CAN_HAVE_STORAGE to not
fall again in this trap in the future. For back-branches, let's just
add the appropriate relkind checks as suggested upthread. Please note
that the attached patch is for HEAD, and I'll adjust for other branches.
The view part needs to go down to v10, and the part for foreign tables
down to v11.


Attachment Content-Type Size
no_heap_opt_fdw_copy-v5.patch text/x-diff 4.8 KB

In response to


Browse pgsql-bugs by date

  From Date Subject
Next Message 孙冰 2018-12-20 12:31:49 Test of value equivalency of row type, feature or bug?
Previous Message David Rowley 2018-12-19 22:24:35 Re: Postgres 11 Insufficient columns in PRIMARY KEY constraint definition