Re: allow online change primary_conninfo

From: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
To: sk(at)zsrv(dot)org
Cc: michael(at)paquier(dot)xyz, andres(at)anarazel(dot)de, pgsql-hackers(at)postgresql(dot)org
Subject: Re: allow online change primary_conninfo
Date: 2018-12-13 09:42:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

At Tue, 11 Dec 2018 13:16:23 +0300, Sergei Kornilov <sk(at)zsrv(dot)org> wrote in <9653601544523383(at)iva8-37fc2ad204cd(dot)qloud-c(dot)yandex(dot)net>
sk> oops, forgot attach patch
sk> 11.12.2018, 13:14, "Sergei Kornilov" <sk(at)zsrv(dot)org>:
sk> > Hello
sk> >
sk> > After some thinking i can rewrite this patch in another way.
sk> >
sk> > This is better or worse?

As the whole the new version looks better for me.

Do we no longer need static version of conninfo/slotname in
walreceiver.c? We can detect a change of the variables without
them (as you did in the previous version.).

I don't think it is acceptable that raw conninfo is exposed into
log file.

> LOG: parameter "primary_conninfo" changed to "host=/tmp port=5432 password=hoge"

> errmsg("closing replication connection because primary_conninfo was changed")));

Maybe it is better being as follows according to similar messages:

> errmsg("terminating walreceiver process due to change of primary_conninfo")));

And it *might* be good to have detail.

> errdetail("In a moment starts streaming WAL with new configuration.");


Kyotaro Horiguchi
NTT Open Source Software Center

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-12-13 10:33:39 alternative to PG_CATCH
Previous Message Simon Riggs 2018-12-13 09:41:39 'infinity'::Interval should be added