Re: Add extension options to control TAP and isolation tests

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Adam Berlin <berlin(dot)ab(at)gmail(dot)com>
Subject: Re: Add extension options to control TAP and isolation tests
Date: 2018-11-29 02:00:11
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Nov 23, 2018 at 09:43:45AM +0900, Michael Paquier wrote:
> That's for the main regression test suite within src/test/regress, TAP
> is also a regression test suite, the page of the link reflects the
> general set of test suites available.

The main patch had to be reverted a couple of days ago via 1d7dd18, and
I have been digging and fixing the set of issues the buildfarm has been
complaining about since. There were two problems:
- MSVC scripts were not able to handle modules with NO_INSTALLCHECK
defined, and runs with the assumption that installcheck is
used. Support for that has been added in 431f159. Some modules have
been also lacking NO_INSTALLCHECK.
- contrib/bloom/ are unstable. I have not spent time investigating the
actual root issue, but spawned a thread with the authors of the tests:

I am attaching the patch I would like to commit to close this thread,
which has as single change TAP_TESTS commented out in contrib/bloom/ to
not explode the buildfarm. Any objections to that?

Attachment Content-Type Size
0001-Add-PGXS-options-to-control-TAP-and-isolation-tests-.patch text/x-diff 17.1 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-29 02:03:54 Re: More issues with pg_verify_checksums and checksum verification in base backups
Previous Message Kyotaro HORIGUCHI 2018-11-29 01:46:17 Re: pg_config wrongly marked as not parallel safe?