Re: [PATCH] XLogReadRecord returns pointer to currently read page

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, hlinnaka(at)iki(dot)fi, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] XLogReadRecord returns pointer to currently read page
Date: 2018-11-20 23:50:28
Message-ID: 20181120235028.GA1951@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 20, 2018 at 06:37:36AM +0500, Andrey Lepikhov wrote:
> On 20.11.2018 6:30, Michael Paquier wrote:
>> Yeah, this one is not entirely true now. What about the following
>> instead:
>> - /* Buffer for current ReadRecord result (expandable) */
>> + /*
>> + * Buffer for current ReadRecord result (expandable), used when a record
>> + * crosses a page boundary.
>> + */
>
> I agree

Okay, I have committed this version, after checking that there were no
other spots.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-20 23:52:17 Re: CF app feature request
Previous Message David Rowley 2018-11-20 23:04:41 Re: A small tweak to some comments for PartitionKeyData