| From: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | alvherre(at)2ndquadrant(dot)com |
| Cc: | david(dot)rowley(at)2ndquadrant(dot)com, kommi(dot)haribabu(at)gmail(dot)com, thomas(dot)munro(at)enterprisedb(dot)com, andres(at)anarazel(dot)de, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Accounting of zero-filled buffers in EXPLAIN (BUFFERS) |
| Date: | 2018-11-19 04:24:08 |
| Message-ID: | 20181119.132408.139732554.horiguchi.kyotaro@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Sat, 17 Nov 2018 11:15:54 -0300, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote in <20181117141554(dot)4dkx2u4j6md3bqdh(at)alvherre(dot)pgsql>
> Is this patch committable now?
I don't think so. We should make a decision on a point.
I was a bit confused (sorry) but IIUIC Haribabu suggested that
the RBM_ZERO_ON_ERROR case should be included to read (not just
ignored). I'm on it. I think that RPM_ZERO_* other than ON_ERROR
cases could be a kind of hit but I don't insist on it.
So, I think we should decide on at least the ON_ERROR case before
this becomes commttable.
The another counter could be another issue. I don't object to add
the counter but I'm not sure what is the suitable name.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-19 04:24:34 | Re: [PATCH] XLogReadRecord returns pointer to currently read page |
| Previous Message | Michael Paquier | 2018-11-19 04:22:13 | Re: Function to promote standby servers |