Re: ALTER INDEX ... ALTER COLUMN not present in dump

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Adrien NAYRAT <adrien(dot)nayrat(at)anayrat(dot)info>
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: ALTER INDEX ... ALTER COLUMN not present in dump
Date: 2018-11-16 08:32:52
Message-ID: 20181116083252.GF6613@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Nov 16, 2018 at 09:45:05AM +0900, Michael Paquier wrote:
> A good thing is that when ALTER INDEX .. SET STATISTICS is applied on an
> index of a partitioned table, the statement is not cascaded to the
> existing partitions. We may want in the future to support ONLY and make
> the inheritance automatic. But that's another topic, and the fix for
> v11 should be chirurgical.

And here you go as attached. Looking closer, in v10 and older versions,
ALTER INDEX SET STATISTICS is able to work as it is an alias of ALTER
TABLE. The attached patch does not bother generating the ALTER INDEX
queries for v10 and older and feeds queries with empty strings. Perhaps
we should support that case? Or the lack of complains would be an
argument sufficient to care only about v11 and newer versions? I would
tend to think that supporting only v11 and above is enough. Thoughts
are welcome.
--
Michael

Attachment Content-Type Size
dump-alter-index-stats.patch text/x-diff 8.2 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2018-11-16 13:31:03 Re: ALTER INDEX ... ALTER COLUMN not present in dump
Previous Message Tom Lane 2018-11-16 05:22:27 Re: BUG #15509: Pg_Dump failed if Database name contains non ascii characters

Browse pgsql-hackers by date

  From Date Subject
Next Message Nikolay Shaplov 2018-11-16 10:52:41 Re: [PATCH] Opclass parameters
Previous Message Amit Langote 2018-11-16 06:47:52 Re: Speeding up INSERTs and UPDATEs to partitioned tables