Re: Restore CurrentUserId only if 'prevUser' is valid when abort transaction

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Richard Guo <riguo(at)pivotal(dot)io>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Restore CurrentUserId only if 'prevUser' is valid when abort transaction
Date: 2018-11-13 06:13:33
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Nov 12, 2018 at 08:17:29PM -0500, Tom Lane wrote:
> I don't like this too much, because it does not scale: there can be
> only one action that can rely on executing "just before we switch to


> I think the real bug here is that a bunch of potentially-failable
> operations have been thrown in before we've finished initializing the
> TransactionState to minimal sanity. (Inserting code with the aid of a
> dartboard seems to be a chronic disease around here :-(.) Since
> GetUserIdAndSecContext is *not* an operation that can fail, there's
> no reason why we need to expend a lot of effort on the possibility that
> it hasn't happened. What we ought to do is move that and the rest of the
> "initialize current transaction state fields" stanza up to before we start
> doing things like calling RecoveryInProgress(). And put in a comment to
> clearly mark where we first allow failure to occur.

When first working on the patch I got to wonder if there were any
intermediate states which relied on the user ID of the security context
flags which could have justified its current position. Just checking
now it looks safe to move up the call. I have checked as well my test
cases injecting errors. What do you think about the attached?

Also, I think that we should backpatch something all the way down.
An ERROR in this code path is perhaps unlikely to happen but having
Postgres to crash if the ERROR shows for the first query of a session is
not nice. Any thoughts about that?

> I'd be strongly inclined to change the elog(WARNING) at line 1815
> to an assertion, because calling elog exposes us to all kinds of
> hazards that we don't need here.

No objections from here. I would do that only on HEAD though.

Attachment Content-Type Size
userid-assert-v3.patch text/x-diff 2.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2018-11-13 06:34:52 Re: doc fix for pg_stat_activity.backend_type
Previous Message Haribabu Kommi 2018-11-13 06:02:02 Re: New function pg_stat_statements_reset_query() to reset statistics of a specific query