From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Disallow setting client_min_messages > ERROR? |
Date: | 2018-11-08 16:06:30 |
Message-ID: | 20181108160630.d257akzmjhkoj7kb@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2018-11-08 10:56:33 -0500, Tom Lane wrote:
> OK, so the consensus seems to be that the back branches should continue
> to allow you to set client_min_messages = FATAL/PANIC, but then ignore
> that and act as though it were ERROR.
Sounds good.
> We could implement the clamp either in elog.c or in a GUC assignment
> hook. If we do the latter, then SHOW and pg_settings would report the
> effective value rather than what you set. That seems a bit cleaner
> to me, and not without precedent. As far as the backwards compatibility
> angle goes, you can invent scenarios in which either choice could be
> argued to break something; but I think the most likely avenue for
> trouble is if the visible setting doesn't match the actual behavior.
> So I'm leaning to the assign-hook approach; comments?
Seems reasonable.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Jonah H. Harris | 2018-11-08 16:09:19 | Re: Disallow setting client_min_messages > ERROR? |
Previous Message | Tom Lane | 2018-11-08 15:56:33 | Re: Disallow setting client_min_messages > ERROR? |