pgbench doc fix

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org
Subject: pgbench doc fix
Date: 2018-10-30 01:36:54
Message-ID: 20181030.103654.2249812451112831300.t-ishii@sraoss.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

pgbench doc (and some comments in pgbench.c) regarding "-M prepared"
option is not quite correct.

------------------------------------------------------------------------
-M querymode
--protocol=querymode

Protocol to use for submitting queries to the server:

simple: use simple query protocol.

extended: use extended query protocol.

prepared: use extended query protocol with prepared statements.
------------------------------------------------------------------------

Actually "extended" mode uses prepared statements too. The only
difference is, in extended mode *unnamed* prepared statements are
used, while in prepared mode *named* prepared statements are used.

Also, in extended query protocol, prepared statements are always used
anyway. Thus "use extended query protocol with prepared statements"
does not give any useful information to users.

I think this should be changed to:

prepared: use extended query protocol with named prepared statements.

Patch attached.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

Attachment Content-Type Size
pgbench.diff text/x-patch 1.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-10-30 01:53:43 Re: partition tree inspection functions
Previous Message Michael Paquier 2018-10-30 01:33:18 Re: partition tree inspection functions