Re: Upper limit arguments of pg_logical_slot_xxx_changes functions accept invalid values

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Upper limit arguments of pg_logical_slot_xxx_changes functions accept invalid values
Date: 2018-10-02 04:49:38
Message-ID: 20181002044938.GT11712@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 14, 2018 at 10:00:49AM +0900, Masahiko Sawada wrote:
> I might be missing something but I think the setting either 0 or
> negative values to it solves this problem. Since the upto_nchanges is
> int32 we cannot build if somebody reverted
> 0ab9d1c4b31622e9176472b4276f3e9831e3d6ba.

I don't link that we should change the existing behavior either which is
here for a couple of releases already, so let's mark the patch as
returned with feedback.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2018-10-02 04:50:46 Re: de-deduplicate code in DML execution hooks in postgres_fdw
Previous Message Michael Paquier 2018-10-02 04:46:13 Re: [PATCH] get rid of StdRdOptions, use individual binary reloptions representation for each relation kind instead