From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Sergei Kornilov <sk(at)zsrv(dot)org> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |
Date: | 2018-09-21 17:43:47 |
Message-ID: | 20180921174347.wvszsn7uk56zvz7o@alap3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Hi,
On 2018-09-21 20:38:16 +0300, Sergei Kornilov wrote:
> > My first question was whether TWO of them were dead code ... isn't an
> > aggressive vacuum to prevent wraparound, and a vacuum to prevent
> > wraparound aggressive?
> Maybe i am wrong, aggressive autovacuum was your commit.
> Message split was in b55509332f50f998b6e8b3830a51c5b9d8f666aa
> Aggressive autovacuum was in fd31cd265138019dcccc9b5fe53043670898bc9f
>
> If aggressive really is wraparound without difference - i think we need refactor this code, it is difficult have two different flags for same purpose.
>
> But as far i can see it is possible have aggressive non-wraparound vacuum. One important difference - regular and aggressive regular can be canceled by backend,.wraparound autovacuum can not. (by checking PROC_VACUUM_FOR_WRAPAROUND in src/backend/storage/lmgr/proc.c )
Yes, without checking the code, they should be different. Aggressive is
controlled by vacuum_freeze_table_age whereas anti-wrap is controlled by
autovacuum_freeze_max_age (but also implies aggressive).
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2018-09-21 19:22:32 | pgsql: Improve tab completion for ANALYZE, EXPLAIN, and VACUUM. |
Previous Message | Sergei Kornilov | 2018-09-21 17:38:16 | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |
From | Date | Subject | |
---|---|---|---|
Next Message | Joe Conway | 2018-09-21 17:51:04 | Re: doc - add missing documentation for "acldefault" |
Previous Message | Sergei Kornilov | 2018-09-21 17:38:16 | Re: pgsql: Improve autovacuum logging for aggressive and anti-wraparound ru |