| From: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
|---|---|
| To: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_verify_checksums -d option (was: Re: pg_verify_checksums -r option) |
| Date: | 2018-08-30 09:10:54 |
| Message-ID: | 20180830181054.a203e6f5eb72d2924b632392@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 30 Aug 2018 10:54:08 +0200
Michael Banck <michael(dot)banck(at)credativ(dot)de> wrote:
> Hi,
>
> On Thu, Aug 30, 2018 at 05:48:24PM +0900, Yugo Nagata wrote:
> > Oops, It's my mistake. I updated the patch.
>
> Looks good to me now.
>
> One could argue that the message could be 'checksums verified in file
> FILE' (plural) rather than 'checksum verified in file FILE', but that is
> quickly approaching bikeshed territory I guess.
It seems to me reasonable. Although I'm not native English speaker, if this
is more natural for Westerners, it is better to fix.
Attached is the revised version.
Regards,
--
Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp>
| Attachment | Content-Type | Size |
|---|---|---|
| 01_pg_veriify_checksum_debug_to_verbose-v5.patch | text/x-diff | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-08-30 09:17:44 | Re: [HACKERS] [PATCH] kNN for SP-GiST |
| Previous Message | Alexander Kukushkin | 2018-08-30 08:55:23 | Re: BUG #15346: Replica fails to start after the crash |