| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
| Cc: | Postgres hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improve behavior of concurrent TRUNCATE |
| Date: | 2018-08-09 16:30:02 |
| Message-ID: | 20180809163002.GJ13638@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 09, 2018 at 03:27:04PM +0000, Bossart, Nathan wrote:
> Thanks! This patch builds cleanly, the new tests pass, and my manual
> testing hasn't uncovered any issues. Notably, I cannot reproduce the
> originally reported authentication issue by using TRUNCATE after this
> change. Beyond a few small comment wording suggestions below, it
> looks good to me.
Thanks, I have updated the patch as you suggested. Any more
improvements to it that you can foresee?
> The second and fourth tests don't seem to actually block.
Yeah, that's intentional.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Refactor-TRUNCATE-execution-to-avoid-too-early-lock-.patch | text/x-diff | 12.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-08-09 16:42:08 | Re: libpq should not look up all host addresses at once |
| Previous Message | Andrew Dunstan | 2018-08-09 16:19:01 | Commitfest 2018-07 RFC items |