Re: Incorrect error handling for two-phase state files resulting in data loss

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Incorrect error handling for two-phase state files resulting in data loss
Date: 2018-07-18 08:18:18
Message-ID: 20180718081818.GG8565@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, Jul 09, 2018 at 02:03:09PM +0900, Michael Paquier wrote:
> I think that we really need to harden things, by making
> ReadTwoPhaseFile() fail hard is it finds something unexpected, which is
> in this case anything except trying to open a file which fails on
> ENOENT, and that this stuff should be back-patched.

Rebased as attached because of the conflicts from 811b6e3.
--
Michael

Attachment Content-Type Size
0001-Fail-hard-when-facing-corrupted-two-phase-state-file.patch text/x-diff 7.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2018-07-18 08:26:44 Re: cursors with prepared statements
Previous Message Heikki Linnakangas 2018-07-18 08:16:37 Re: [HACKERS] Re: [COMMITTERS] pgsql: Remove pgbench "progress" test pending solution of its timing is (fwd)