Re: Fix some error handling for read() and errno

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robbie Harwood <rharwood(at)redhat(dot)com>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, hlinnaka <hlinnaka(at)iki(dot)fi>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Subject: Re: Fix some error handling for read() and errno
Date: 2018-07-13 13:38:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Mon, Jun 25, 2018 at 04:18:18PM +0900, Michael Paquier wrote:
> As this one is done, I have been looking at that this thread again.
> Peter Eisentraut has pushed as e5d11b9 something which does not need to
> worry about pluralization of error messages. So I have moved to this
> message style for all messages. All of this is done as 0001.

Mr. Robot has been complaining about this patch set, so attached is a
rebased version. Thinking about it, I would tend to just merge 0001 and
give up on 0002 as that may not justify future backpatch pain. Thoughts
are welcome.

Attachment Content-Type Size
0001-Rework-error-messages-around-file-handling.patch text/x-diff 22.7 KB
0002-Add-interface-to-read-write-fsync-with-transient-fil.patch text/x-diff 16.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-07-13 13:40:42 Re: file cloning in pg_upgrade and CREATE DATABASE
Previous Message Ashutosh Bapat 2018-07-13 13:36:08 Re: partition pruning doesn't work with IS NULL clause in multikey range partition case