Re: [HACKERS] Custom compression methods

From: Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>
To: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Cc: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>, Ildar Musin <i(dot)musin(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Евгений Шишкин <itparanoia(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Oleg Bartunov <obartunov(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Chapman Flack <chap(at)anastigmatix(dot)net>
Subject: Re: [HACKERS] Custom compression methods
Date: 2018-07-02 12:56:24
Message-ID: 20180702155624.542860bc@wp.localdomain
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Mon, 18 Jun 2018 17:30:45 +0300
Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru> wrote:

> On Tue, 24 Apr 2018 14:05:20 +0300
> Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>
> >
> > Yes, this patch definitely lacks of good usage example. That may
> > lead to some misunderstanding of its purpose. Good use-cases
> > should be shown before we can consider committing this. I think
> > Ildus should try to implement at least custom dictionary compression
> > method where dictionary is specified by user in parameters.
> >
>
> Hi,
>
> attached v16 of the patch. I have splitted the patch to 8 parts so now
> it should be easier to make a review. The main improvement is zlib
> compression method with dictionary support like you mentioned. My
> synthetic tests showed that zlib gives more compression but usually
> slower than pglz.
>

Hi,
I have noticed that my patch is failing to apply on cputube. Attached a
rebased version of the patch. Nothing have really changed, just added
and fixed some tests for zlib and improved documentation.

--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company

Attachment Content-Type Size
0001-Make-syntax-changes-for-custom-compression-metho-v17.patch text/x-patch 9.1 KB
0002-Add-compression-catalog-tables-and-the-basic-inf-v17.patch text/x-patch 114.0 KB
0003-Add-rewrite-rules-and-tupdesc-flags-v17.patch text/x-patch 24.4 KB
0004-Add-pglz-compression-method-v17.patch text/x-patch 7.5 KB
0005-Add-zlib-compression-method-v17.patch text/x-patch 9.9 KB
0006-Add-psql-pg_dump-and-pg_upgrade-support-v17.patch text/x-patch 37.2 KB
0007-Add-tests-for-compression-methods-v17.patch text/x-patch 150.6 KB
0008-Add-documentation-for-custom-compression-methods-v17.patch text/x-patch 17.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2018-07-02 12:58:38 Re: branches_of_interest.txt
Previous Message Robert Haas 2018-07-02 12:33:42 Re: branches_of_interest.txt