| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: documentation fixes for partition pruning, round two |
| Date: | 2018-05-24 05:19:15 |
| Message-ID: | 20180524051915.GO30060@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 24, 2018 at 11:30:40AM +0900, Amit Langote wrote:
> Hi Justin.
>
> Thanks for writing the patch. I have a couple of comments.
Thanks for your review, find attached updated patch.
> + possible to show the difference between a plan whose partitions have been
> + pruned and one whose partitions haven't. A typical unoptimized plan for
> + this type of table setup is:
>
> "a plan whose partitions have been pruned" sounds a bit off; maybe, "a
> plan in which partitions have been pruned".
I wrote:
"[...] a plan for which partitions have been pruned and for which they have
not."
Cheers,
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v2-doc-fix-partitioning-round2 | text/plain | 13.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Borodin | 2018-05-24 06:30:05 | Re: Error on vacuum: xmin before relfrozenxid |
| Previous Message | Tom Lane | 2018-05-24 03:48:54 | Re: PG11 jit failing on ppc64el |