Re: [PROPOSAL] Shared Ispell dictionaries

From: Arthur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PROPOSAL] Shared Ispell dictionaries
Date: 2018-03-22 10:56:05
Message-ID: 20180322105603.GA23544@zakirov.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Mar 21, 2018 at 12:00:52PM +0300, Arthur Zakirov wrote:
> On Tue, Mar 20, 2018 at 09:30:15PM +0100, Tomas Vondra wrote:
> > I wonder if these restrictions needed? I mean, why not to allow setting
> > max_shared_dictionaries_size below the size of loaded dictionaries?
> >
> > Of course, on the one hand those restriction seem sensible. On the other
> > hand, perhaps in some cases it would be useful to allow violating them?
> >
> > I mean, why not to simply disable loading of new dictionaries when
> >
> > (max_shared_dictionaries_size < loaded_size)
> >
> > Maybe I'm over-thinking this though. It's probably safer and less
> > surprising to enforce the restrictions.
> Hm, yes in some cases this check may be over-engineering. I thought that
> it is reasonable and safer in v7 patch. But there are similar GUCs,
> wal_keep_segments and max_wal_size, which don't do additional checks.
> And people are fine with them. So I removed that check from the variable.
> Please find the attached new version of the patch.

I forgot to fix regression tests for max_shared_dictionaries_size. Also
I'm not confident about using pg_reload_conf() in regression tests.
I haven't found where pg_reload_conf() is used in tests. So I removed
max_shared_dictionaries_size tests for now.

Sorry for the noise.

Arthur Zakirov
Postgres Professional:
Russian Postgres Company

Attachment Content-Type Size
0001-Fix-ispell-memory-handling-v10.patch text/plain 1.2 KB
0002-Change-tmplinit-argument-v10.patch text/plain 7.9 KB
0003-Retreive-shared-location-for-dict-v10.patch text/plain 17.6 KB
0004-Store-ispell-in-shared-location-v10.patch text/plain 89.3 KB
0005-pg-ts-shared-dictinaries-view-v10.patch text/plain 9.3 KB
0006-Shared-memory-ispell-option-v10.patch text/plain 8.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Pavan Deolasee 2018-03-22 11:48:19 Re: ON CONFLICT DO UPDATE for partitioned tables
Previous Message Jeevan Chalke 2018-03-22 10:27:31 Re: [HACKERS] Partition-wise aggregation/grouping