Re: SSL passphrase prompt external command

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SSL passphrase prompt external command
Date: 2018-03-17 23:59:07
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Mar 16, 2018 at 12:07:59PM -0400, Peter Eisentraut wrote:
> On 3/15/18 12:13, Daniel Gustafsson wrote:
>> * In src/tools/msvc/
>> # if building without OpenSSL
>> if (!$solution->{options}->{openssl})
>> {
>> + $postgres->RemoveFile('src/backend/libpq/be-secure-common.c');
>> $postgres->RemoveFile('src/backend/libpq/be-secure-openssl.c');
>> }
>> Is this because run_ssl_passphrase_command() would otherwise generate a warning
>> due to not being used?
> I have no idea. ;-) It's the same thing I was told to do for
> fe-secure-common.c a while back.

I don't recall saying exactly that either :)

You need to filter out OpenSSL-only code when MSVC builds without
OpenSSL because it includes all files listed in a path by default. No
need to make compilation include files which are not necessary. This
change is correct by the way.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chapman Flack 2018-03-18 00:22:08 Re: [HACKERS] AdvanceXLInsertBuffer vs. WAL segment compressibility
Previous Message Michael Paquier 2018-03-17 23:49:01 Re: [bug fix] Cascaded standby cannot start after a clean shutdown