| From: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Stephen Frost <sfrost(at)snowman(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Verify Checksums during Basebackups |
| Date: | 2018-03-17 21:34:35 |
| Message-ID: | 20180317213434.GA469@nighthawk.caipicrew.dd-dns.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Fri, Mar 09, 2018 at 10:35:33PM +0100, Michael Banck wrote:
> Possibly open questions:
>
> 1. I have not so far changed the replication protocol to make verifying
> checksums optional. I can go about that next if the consensus is that we
> need such an option (and cannot just check it everytime)?
I think most people (including those I had off-list discussions about
this with) were of the opinion that such an option should be there, so I
added an additional option NOVERIFY_CHECKSUMS to the BASE_BACKUP
replication command and also an option -k / --no-verify-checksums to
pg_basebackup to trigger this.
Updated patch attached.
Michael
--
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax: +49 2166 9901-100
Email: michael(dot)banck(at)credativ(dot)de
credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
| Attachment | Content-Type | Size |
|---|---|---|
| basebackup-verify-checksum-V3.patch | text/x-diff | 16.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chapman Flack | 2018-03-17 23:10:20 | Re: pgbench randomness initialization |
| Previous Message | Tomas Vondra | 2018-03-17 21:06:35 | Re: strange failure in plpgsql_control tests (on fulmar, ICC 14.0.3) |